Revert unintended test expectation change #9625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit fbe3059 included an unintended change to the test which checks if dns_get_record populates its additional parameter. This patch reverts such change. The issue was not detected by the CIs because their tests run in the --offline mode, and the test in question needs internet connection.
|
Indeed, expecting |
|
Oh my bad.. When running the test locally (I use a Mac), I got this result, then I used bless_test.php and I didn't notice the change. :( |
cmb69
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fbe3059 included an unintended change to the test which checks if dns_get_record populates its additional parameter. This patch reverts such change.
The issue was not detected by the CIs because their tests run in the --offline mode, and the test in question needs internet connection.